Rescue Faraday::ConnectionFailed #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to figure out why CI isn't running... |
stanhu
added a commit
to stanhu/oauth2
that referenced
this pull request
Jun 23, 2022
If Faraday hits a timeout, it will raise a `Faraday::TimeoutError`. Re-raise this as an `OAuth2::ConnectionError`, reusing the logic in oauth-xx#549. This came up in omniauth/omniauth-oauth2#129.
stanhu
added a commit
to stanhu/oauth2
that referenced
this pull request
Jun 23, 2022
If Faraday hits a timeout, it will raise a `Faraday::TimeoutError`. Re-raise this as an `OAuth2::ConnectionError`, reusing the logic in oauth-xx#549. This came up in omniauth/omniauth-oauth2#129.
stanhu
added a commit
to stanhu/oauth2
that referenced
this pull request
Jun 23, 2022
If Faraday hits a timeout, it will raise a `Faraday::TimeoutError`. Re-raise this as an `OAuth2::ConnectionError`, reusing the logic in oauth-xx#549. This came up in omniauth/omniauth-oauth2#129.
stanhu
added a commit
to stanhu/oauth2
that referenced
this pull request
Jun 24, 2022
If Faraday hits a timeout, it will raise a `Faraday::TimeoutError`. Re-raise this as an `OAuth2::ConnectionError`, reusing the logic in oauth-xx#549. This came up in omniauth/omniauth-oauth2#129.
pboling
pushed a commit
that referenced
this pull request
Jun 24, 2022
* Rescue Faraday::TimeoutError If Faraday hits a timeout, it will raise a `Faraday::TimeoutError`. Re-raise this as an `OAuth2::ConnectionError`, reusing the logic in #549. This came up in omniauth/omniauth-oauth2#129. * Break out OAuth2::Client#request This resolves several Rubocop lint errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #152
Faraday::ConnectionFailedasOAuth2::ConnectionFailed