You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems the helm chart mixes the use of "args" and "envs" for configuring the container.
One example use case (which I guess is common) is to have an org-wide set of sensible defaults in a values.yaml file, and then override or supplement on an app-by-app or env-by-env basis.
Things like clientId and clientSecret are kind of handled explicitly so they support this easily.
But we have specific settings such as --oidc-issuer-url= that can vary. The problem with the charts extraArgs and extraEnv is they cannot easily be created from multiple sources (values files or use of --set). They both need to be configured in their entirety in one (or every) place. Some more information here: https://helm.sh/docs/chart_best_practices/values/#consider-how-users-will-use-your-values
The "best" way to support this would be to explicitly support every argument to oauth2-proxy in the helm chart. But that is probably too much work and maintenance overhead to be feasible.
Therefore I propose adding support from reading in env vars from a ConfigMap via envFrom. That would give us another tool/angle to work with. For example org-wide configuration could be stored in a ConfigMap that is loaded via envFrom, and then individual deployments are free to "own" and set all necessary configuration with extraEnv without deeper knowledge of the inherited org-wide config that is stored separately in one (or more) ConfigMaps.
The text was updated successfully, but these errors were encountered:
It seems the helm chart mixes the use of "args" and "envs" for configuring the container.
One example use case (which I guess is common) is to have an org-wide set of sensible defaults in a values.yaml file, and then override or supplement on an app-by-app or env-by-env basis.
Things like
clientId
andclientSecret
are kind of handled explicitly so they support this easily.But we have specific settings such as
--oidc-issuer-url=
that can vary. The problem with the chartsextraArgs
andextraEnv
is they cannot easily be created from multiple sources (values files or use of--set
). They both need to be configured in their entirety in one (or every) place. Some more information here: https://helm.sh/docs/chart_best_practices/values/#consider-how-users-will-use-your-valuesThe "best" way to support this would be to explicitly support every argument to oauth2-proxy in the helm chart. But that is probably too much work and maintenance overhead to be feasible.
Therefore I propose adding support from reading in env vars from a ConfigMap via
envFrom
. That would give us another tool/angle to work with. For example org-wide configuration could be stored in a ConfigMap that is loaded viaenvFrom
, and then individual deployments are free to "own" and set all necessary configuration withextraEnv
without deeper knowledge of the inherited org-wide config that is stored separately in one (or more) ConfigMaps.The text was updated successfully, but these errors were encountered: