Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursion support #24

Closed
meowtec opened this issue Dec 19, 2019 · 4 comments
Closed

Recursion support #24

meowtec opened this issue Dec 19, 2019 · 4 comments

Comments

@meowtec
Copy link

meowtec commented Dec 19, 2019

For example, I installed query-string which is ES6, and some dependencies of query-string are also ES6. are-you-es5 only found query-string.

@obahareth
Copy link
Owner

Hey @meowtec, right now the solution for this is to use the --all option when running are-you-es5. It will check all the node modules instead of just direct dependencies. Does this solve your issue?

@meowtec
Copy link
Author

meowtec commented Dec 20, 2019

Hey @meowtec, right now the solution for this is to use the --all option when running are-you-es5. It will check all the node modules instead of just direct dependencies. Does this solve your issue?

Maybe not.
It found too many packages most of which were / were used by devDependencies.

Like this:

/[\\/]node_modules[\\/](?!(abab|ansi-align|ansi-escapes|ansi-styles|ast-types-flow|astral-regex|boxen|caller-callsite|chalk|chownr|cli-cursor|configstore|constants-browserify|cosmiconfig|cross-env|cross-spawn|crypto-random-string|css-color-names|cssstyle|dashdash|data-urls|del|detect-indent|dir-glob|dot-prop|eslint|eslint-plugin-eslint-plugin|eslint-plugin-import|eslint-plugin-react|eslint-scope|eslint-visitor-keys|execa|expect|figures|file-entry-cache|find-cache-dir|find-up|get-stream|getpass|global-dirs|globby|got|graceful-process|has-flag|home-or-tmp|hoopy|html-encoding-sniffer|import-cwd|import-fresh|import-from|import-lazy|import-local|is-ali-env|is-fullwidth-code-point|is-installed-globally|is-wsl|jest-changed-files|jest-cli|jest-config|jest-diff|jest-docblock|jest-environment-jsdom|jest-environment-node|jest-get-type|jest-haste-map|jest-jasmine2|jest-leak-detector|jest-matcher-utils|jest-message-util|jest-mock|jest-regex-util|jest-resolve|jest-resolve-dependencies|jest-runner|jest-runtime|jest-serializer|jest-snapshot|jest-util|jest-worker|jsdom|jsesc|json-parse-better-errors|latest-version|load-json-file|loader-utils|locate-path|lodash-es|make-dir|map-age-cleaner|mem|mimic-fn|npm-package-arg|npm-run-path|onetime|opn|os-locale|p-defer|p-finally|p-is-promise|p-limit|p-locate|p-map|p-try|package-json|path-exists|path-key|path-type|pirates|pkg-dir|pkg-up|postcss-load-config|postcss-modules-extract-imports|pretty-bytes|pretty-format|promise-inflight|query-string|read-pkg|read-pkg-up|realpath-native|regexpp|regexpu-core|resolve-cwd|restore-cursor|selfsigned|slice-ansi|split-on-first|ssri|strict-uri-encode|string-length|string-width|strip-bom|strip-indent|superagent|supports-color|symbol-tree|term-size|test-exclude|tmp|to-fast-properties|tr46|tslint|umi-notify|umi-test|unicode-match-property-ecmascript|unicode-match-property-value-ecmascript|unique-string|universalify|unzip-response|update-notifier|w3c-hr-time|webidl-conversions|whatwg-encoding|whatwg-mimetype|widest-line|window-size|write-file-atomic|write-json-file|ws|xdg-basedir|xml-name-validator|yargs)[\\/])/

2098 chars

While I only want to exclude query-string and its ES6 dependencies

@obahareth
Copy link
Owner

I'll probably be able to experiment with a fix for this early next year, probably either trying out recursion or a variation of -all that excludes dev dependencies.

@obahareth
Copy link
Owner

Further discussion should happen on #2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants