Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coap_get_data() sets not exactly right pointer #4

Closed
DoumanAsh opened this issue Sep 2, 2015 · 2 comments
Closed

coap_get_data() sets not exactly right pointer #4

DoumanAsh opened this issue Sep 2, 2015 · 2 comments

Comments

@DoumanAsh
Copy link

The actual data is stored in position pdu->data++;
https://github.com/obgm/libcoap/blob/develop/src/pdu.c#L264

But the set value will be pdu->data which is COAP_PAYLOAD_START
So user must pay attention to that and increment data to get actual payload.

I would suggest to consider actually mentioning it in function description or change it return pointer to actual payload.

BTW: Also question is the same for received PDU?
From my experience it seems not to be so.

p.s. the problem is detected by valgrind when i trying to verify payload of created pdu
@DoumanAsh
Copy link
Author

Seems like i'm a bit misunderstood valgrind...
And seems like i misunderstood code too...

Sorry about that

@obgm
Copy link
Owner

obgm commented Sep 2, 2015 via email

@mbaril mbaril mentioned this issue Jun 5, 2018
Closed
@mrdeep1 mrdeep1 mentioned this issue Jul 26, 2018
Merged
@leenowell leenowell mentioned this issue Mar 11, 2019
Closed
@zyingp zyingp mentioned this issue Aug 7, 2020
Closed
@wfeii1980 wfeii1980 mentioned this issue Jul 19, 2021
Closed
mrdeep1 added a commit to mrdeep1/libcoap that referenced this issue Nov 5, 2022
@mrdeep1
Update for primary commit obgm#4 (to be squashed later)
af1d6a5
mrdeep1 added a commit to mrdeep1/libcoap that referenced this issue Nov 5, 2022
@mrdeep1
Update for primary commit obgm#4 (to be squashed later)
359458c
mrdeep1 added a commit to mrdeep1/libcoap that referenced this issue Nov 5, 2022
@mrdeep1
Update for primary commit obgm#4 (to be squashed later)
0084480
mrdeep1 added a commit to mrdeep1/libcoap that referenced this issue Nov 5, 2022
@mrdeep1
Update for primary commit obgm#4 (to be squashed later)
4f50c36
mrdeep1 added a commit to mrdeep1/libcoap that referenced this issue Nov 5, 2022
@mrdeep1
Update for primary commit obgm#4 (to be squashed later)
5492767
mrdeep1 added a commit to mrdeep1/libcoap that referenced this issue Nov 7, 2022
@mrdeep1
Update for primary commit obgm#4 (to be squashed later)
762dce0
mrdeep1 added a commit to mrdeep1/libcoap that referenced this issue Nov 28, 2022
@mrdeep1
Update for primary commit obgm#4 (to be squashed later)
7a58003
mrdeep1 added a commit to mrdeep1/libcoap that referenced this issue Nov 30, 2022
@mrdeep1
Update for primary commit obgm#4 (to be squashed later)
d727992
mrdeep1 added a commit to mrdeep1/libcoap that referenced this issue Dec 9, 2022
@mrdeep1
Update for primary commit obgm#4 (to be squashed later)
01a85d4
mrdeep1 added a commit to mrdeep1/libcoap that referenced this issue Dec 13, 2022
@mrdeep1
Update for primary commit obgm#4 (to be squashed later)
25f543b
mrdeep1 added a commit to mrdeep1/libcoap that referenced this issue Dec 17, 2022
@mrdeep1
Update for primary commit obgm#4 (to be squashed later)
8c28d7b
mrdeep1 added a commit to mrdeep1/libcoap that referenced this issue Dec 20, 2022
@mrdeep1
Update for primary commit obgm#4 (to be squashed later)
18f8915
mrdeep1 added a commit to mrdeep1/libcoap that referenced this issue Dec 30, 2022
@mrdeep1
Update for primary commit obgm#4 (to be squashed later)
07aaa25
mrdeep1 added a commit to mrdeep1/libcoap that referenced this issue Dec 30, 2022
@mrdeep1
Update for Interopability Tests obgm#4 (to be squashed later)
e802d08
mrdeep1 added a commit to mrdeep1/libcoap that referenced this issue Jan 2, 2023
@mrdeep1
Update for primary commit obgm#4 (to be squashed later)
c14d144
mrdeep1 added a commit to mrdeep1/libcoap that referenced this issue Jan 2, 2023
@mrdeep1
Update for Interopability Tests obgm#4 (to be squashed later)
a045383
@salmeghlef salmeghlef mentioned this issue Jul 14, 2023
Closed
@fun-works fun-works mentioned this issue May 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DoumanAsh @obgm