Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try Zlib instead of DEFLATE when de-compression PFCS #18

Closed
ultimaweapon opened this issue Oct 25, 2022 · 3 comments
Closed

Try Zlib instead of DEFLATE when de-compression PFCS #18

ultimaweapon opened this issue Oct 25, 2022 · 3 comments
Assignees
@VocalFan
Labels
T-enhancement Type: Enhancement
Milestone
PKG Installer

Comments

@ultimaweapon
Copy link
Member

I guess the actual algorithm is Zlib, not DEFLATE because the current code need to skip the first 2 bytes, which I suspect it is Zlib header.
@ultimaweapon ultimaweapon added C-PFS T-enhancement Type: Enhancement labels Oct 25, 2022
@VocalFan
Copy link
Member

Looking into it, it does seem to use zlib for compression and decompression.

@ultimaweapon
Copy link
Member Author

Try replace Decompress with https://docs.rs/flate2/1.0.24/flate2/read/struct.ZlibDecoder.html.

@VocalFan
Copy link
Member

VocalFan commented Nov 2, 2022

Fixed by commit 0d5286d setting Decompress to use and expect Zlib headers.

@VocalFan VocalFan closed this as completed Nov 2, 2022
@ultimaweapon ultimaweapon linked a pull request Nov 2, 2022 that will close this issue
ZLib implementation test. #39
Closed
@ultimaweapon ultimaweapon added this to the PKG Installer milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VocalFan VocalFan

Labels
T-enhancement Type: Enhancement
Milestone
PKG Installer
Development

Successfully merging a pull request may close this issue.

ZLib implementation test. obhq/obliteration
2 participants
@ultimaweapon @VocalFan