-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1246 add Home.load() function #1344
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
63648bf
refactor(#1246): reformat java docs
volodya-lombrozo e214317
feat(#1246): load file content by path
volodya-lombrozo c95e3ac
feat*(#1246): remove todo comment
volodya-lombrozo a1edc29
refactor(#1246): remove emoty lines
volodya-lombrozo 416b0de
refactor(#1246): remove emoty lines
volodya-lombrozo dd41290
feat(#1246): remove instance of statement
volodya-lombrozo cb9060a
refactor(#1246): remove blank lines in imports
volodya-lombrozo b7102f6
refactor(#1246): remove blank lines in imports
volodya-lombrozo b24ceca
refactor(#1246): fix indentation problems
volodya-lombrozo 8cc63d4
refactor(#1246): fix indentation problems
volodya-lombrozo c7fc275
refactor(#1246): remove empty lines
volodya-lombrozo 737bfc4
refactor(#1246): fix names of variables
volodya-lombrozo 9d66e83
refactor(#1246): fix names of variables
volodya-lombrozo a671977
refactor(#1246): add final modifier for exceptions
volodya-lombrozo 36294a4
refactor(#1246): fix remain codestyle problems
volodya-lombrozo d6ab41a
refactor(#1246): loadBytesFromExistedFile -> loadBytesFromExistingFile
volodya-lombrozo 3c631b0
feat(#1246): use Assertions.assertThrows
volodya-lombrozo ee5389d
feat(#1246): use load method in CopyMojoTest
volodya-lombrozo 6a2b6fc
refactor(#1246): fix all linter mistakes
volodya-lombrozo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@volodya-lombrozo it's better to use
Assertions.assertThrows
from JUnit 5There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. BTW, can we use JUnit assertions instead of
MatcherAssert
in orher places?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@volodya-lombrozo we use them somewhere, but JUnit assertions are way less powerful than Hamcrest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@volodya-lombrozo For consistency I'd use
MatcherAssert
everywhere for matching.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mximp Even for exceptions?