Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1246 add Home.load() function #1344

Merged
merged 19 commits into from
Oct 20, 2022

Conversation

volodya-lombrozo
Copy link
Member

@volodya-lombrozo volodya-lombrozo commented Oct 18, 2022

Add Home.load() function together with unit tests. Also small refactoring was perfomed in the correlated files.
Issue: #1246

@volodya-lombrozo volodya-lombrozo changed the title #1246 add Home.load()function #1246 add Home.load() function Oct 18, 2022
@mximp
Copy link
Contributor

mximp commented Oct 19, 2022

@volodya-lombrozo please run the build locally with Qulice enabled within parent module:

mvn clean install -Pqulice --errors --batch-mode

@mximp mximp self-requested a review October 19, 2022 08:07
Copy link
Contributor

@mximp mximp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code style fixes are required

@volodya-lombrozo
Copy link
Member Author

@mximp pls, take a look for recent changes

}

@Test
void loadFromAbsentFile(@TempDir final Path temp) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@volodya-lombrozo it's better to use Assertions.assertThrows from JUnit 5

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. BTW, can we use JUnit assertions instead of MatcherAssert in orher places?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. BTW, can we use JUnit assertions instead of MatcherAssert in orher places?

@volodya-lombrozo we use them somewhere, but JUnit assertions are way less powerful than Hamcrest.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@volodya-lombrozo For consistency I'd use MatcherAssert everywhere for matching.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mximp Even for exceptions?

@yegor256
Copy link
Member

@volodya-lombrozo maybe it's good to use this new function somewhere in the code? Otherwise, it's not clear what it's for...

@volodya-lombrozo
Copy link
Member Author

@volodya-lombrozo maybe it's good to use this new function somewhere in the code? Otherwise, it's not clear what it's for...

I've used load method in CopyMojoTest class.

@yegor256
Copy link
Member

@rultor merge

}

@Test
void loadFromAbsentFile(@TempDir final Path temp) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@volodya-lombrozo For consistency I'd use MatcherAssert everywhere for matching.

@rultor
Copy link
Contributor

rultor commented Oct 20, 2022

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit cb26e8d into objectionary:master Oct 20, 2022
@rultor
Copy link
Contributor

rultor commented Oct 20, 2022

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 7min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants