-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work for <Text> inside <View> #1
Comments
Hi, you're right it doesn't work and I'm not sure why. For the time being do something like this instead: <Shimmer>
<Text>Hello{'\n'}Hello{'\n'}Hello</Text>
</Shimmer> |
Haha I wish. I was actually trying to do the following.. and then tested with the earlier example I gave (because it is simpler).. I realized that a
|
Hmm, that kinda looks like something you could easily solve with an image, no? |
Yes. I could. That is a very ugly solution though. Especially in my case because I need to have multiple of those views inside Shimmer to support all iPhone and iPad screen sizes and orientations. |
Hi @oblador any plans to work on this? |
Is this package still maintained? Would love to use the shimmering for a skeleton view. But it'd be quite useless without support for views. Maybe I could allocate some time to look into the issue in the next month. Does it work properly on Android, or is it broken on both iOS and Android? |
It is maintained, although this library is merely a wrapper for native libraries from Facebook which as far as I gather has this limitation. I'd be grateful if you spent some time to investigate it further and would merge a fix. |
Why do you think the Facebook library has that limitation? I haven't used it, but I thought it's what Facebook build for the paper app and is still using for the loading animation in its app today, in those skeletons views it's certainly not Text that's shimmering. |
Because it has problems with nested views in general. You can acheive that effect with an image too. |
Hello @oblador. Thanks for your amazing libraries like react-native-vector-icons and react-native-shimmer. I am currently facing an issue with the shimmer. It just doesn't work with Multiples components inside the Shimmer. In iOS works perfect. I am gonna try to check what caused this problem |
@AugustoAleGon did you ever get anywhere with this? |
I think if this is a limitation of the native libraries we're binding to we can easily work around it by walking the node tree and wrapping all leaf nodes (children who have no children which are views) in the native component Otherwise we could ask the native library authors if they could? |
This works with
But for any other kind of views, it does not work.
For example, if I have a bunch of texts inside a View, it won't work.
The text was updated successfully, but these errors were encountered: