-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCF validation invalids picked up #18
Comments
-- | -- | -- | -- | -- | -- |
Is there a quick summary of how to read these? For the first one it seems there is an implicit rdfs:subClassOf between s and o? And 'user' is a user's mapping?
Which OWL axiom is this? Is the root of this issue: id: UBERON:0007225 Which is a little odd - some regions are "organ part" some are "regional part of brain". I think we could do a search and replace on these just for structural consistency |
o is object and s is subject - so it looks for s part_of o (or subclass of, overlaps, connected to, develops from) In general I wouldn't bother looking too much into this for now - we have a new list of expert curated bridge that I'm working on to update the bridge file. After which we plan to re-run the CCF validation on that, so hopefully all these will be gone after that :) |
I'm also thinking of running boomer on Uberon + ABAs which may overlap with this QC check |
The headers were designed for reporting on ASCT+B tables user_slabel and user_olabel = the names given to subject and object of the relationship in the tables. In our repurposing, these correspond to child and parent term in the structureGraph. I think these would be easier to read if the user_olabel and user_slabel had the form 'label ; id' Note - |
Working through some examples (just documenting - no need to reply) Looks like this might be a genuine difference in definition and composition of zones between ABA and Uberon
This one could also be a genuine difference in how nuclei are grouped, this time by partitioning of the thalamus (or it could be that Uberon just didn't partition this nucleus.
This one might be overlap:
|
@dosumis I'm using this ticket for examples that are picked up that I think are good: (still working on it, I've just gotten a version with labels for the aba stuff, so might do a better job here)
Currently the most amount of non_valids are coming from terms that are mapped to regional part of brain
Regional part of brain cannot be part of a smaller unit. example:
Developmental structure as part_of any part of the brain
Example: mesomere 1 part_of midbrain (also part_of regional part of brain)
In Uberon developmental parts are subclassof future brain rather than brain
Looks like a good one but I need to do more research (leave this with me, I'll figure this out):
Examples:
6a. Should be (I THINK) connected_to instead of part_of (will make sure this is not overlaps too, but I'm guessing lateral and posterior would be separate
6b. Things that are not in the brain (I'm guessing its an issue of connected_to also)
The text was updated successfully, but these errors were encountered: