Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HP_0000126 Hydronephrosis and HP_0010946 Dilatation of the renal pelvis are inferred to be equivalent #197

Closed
nicolevasilevsky opened this issue Sep 12, 2016 · 1 comment
Assignees

Comments

@nicolevasilevsky
Copy link
Member

nicolevasilevsky commented Sep 12, 2016

HP_0000126 Hydronephrosis and HP_0010946 Dilatation of the renal pelvis are inferred to be equivalent

HP_0000126 Hydronephrosis
'has part' some
(dilated and ('inheres in' some 'renal pelvis') and ('has modifier' some abnormal))

text def
Severe distention of the kidney with dilation of the renal pelvis and calices.

HP_0010946 Dilatation of the renal pelvis
'has part' some
'has part' some
(dilated and ('inheres in' some 'renal pelvis') and ('has modifier' some abnormal))

text def
The presence of dilatation of the renal pelvis.

These terms have the same logical definitions.

Should the logical definition for hydronephrosis use distended instead of dilated?

Related to #149

@cmungall @pnrobinson

@nicolevasilevsky
Copy link
Member Author

Removed the logical def for HP_0000126 Hydronephrosis, per Seb's guidelines in #149

If the two terms are highly similar, but one of them has a text-def that clearly separates him from the other term, and we don't have way to express this difference in OWL, remove the logical def of the more specific class. (Check set of ancestor classes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants