Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge headers on send #5

Closed
Swaagie opened this issue Dec 31, 2016 · 1 comment
Closed

Merge headers on send #5

Swaagie opened this issue Dec 31, 2016 · 1 comment

Comments

@Swaagie
Copy link
Member

Swaagie commented Dec 31, 2016

Headers options are currently not merged. Specifying

headers: {    
  'Reply-To': body.email
}

will send a plain text e-mail since the content-type is overruled. Doing a deep merge should fix this issue as it still allows overruling default headers.
@Swaagie
Copy link
Member Author

Swaagie commented Dec 31, 2016

Ignore my ramblings, it failed due to not escaping the generated HTML from markdown

@Swaagie Swaagie closed this as completed Dec 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Swaagie