Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crush level 2 brakes on underscore.js #25

Closed
Swaagie opened this issue Jun 14, 2012 · 2 comments
Closed

Crush level 2 brakes on underscore.js #25

Swaagie opened this issue Jun 14, 2012 · 2 comments
Labels

Comments

@Swaagie
Copy link
Member

Swaagie commented Jun 14, 2012

The default crush level 2 brakes underscore.js, I used it in combination with backbone.js and zepto.js, but removing either persisted in the error. Setting the crush level to 5 however, solved the problem.

Possible fix: crush level per file

Config attached for easy reproduction.

{
    "configuration": {
        "dist": "/var/www/temp/{ext}/core.{type}.{ext}"
      , "jshint": {
            "laxcomma": false
        }
      , "plugins": {
            "crush": {
                "level": 2
            }   
        }
    }
  , "bundle": {
        "zepto.js": {
            "description": "Zepto.js"
          , "version": "v1.0rc1"
          , "latest": "http://zeptojs.com/zepto.min.js"
        }
      , "underscore.js": {
            "description": "Underscore"
          , "version": "1.3.3"
          , "latest": "http://code.jquery.com/underscore.js"
        }
      , "backbone.js": {
            "description": "Backbone"
          , "version": "0.9.2"
          , "latest": "http://code.jquery.com/backbone.js"
        }
    }
}
@3rd-Eden
Copy link
Member

Gonna look in to it on Monday, as this probably also created the huge issues we on tuesday.

@3rd-Eden
Copy link
Member

Fixed by reverting my UTF-8 charset changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants