-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: split CSS class tasks-modal-section
#2804
refactor: split CSS class tasks-modal-section
#2804
Conversation
There is only one checkbox anyways
…es to tasks-modal-dependencies-section and do not use the former
…ained that class There is no point in having a <div> that just contains the <form>. Better merge those and remove a level of nesting
…to tasks-modal class
This is now insured by the order of elements
@claremacrae the diff of the |
tests/ui/EditTask.test.Edit_Modal_HTML_snapshot_tests_should_match_snapshot.approved.html
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I viewed the final diffs and they made sense. I did a very very quick test that of the dialog and it behaved fine.
Just a minor comment for my own education...
Description
tasks-modal-section
class into classes depending on their content (date, recurrence, description, etc)<section>
elements to make the HTML code more explicit semantically<div>
at the top level of the modal)Motivation and Context
Make possible extraction of components from
EditTask.scss
andEditTask.svelte
. Now CSS classtasks-modal-section
contains properties related to all the sections (dependencies, dates, description, etc) that makes that impossible.How has this been tested?
Some changes were covered by unit tests, but most of them verified by manual test in demo vault.
Screenshots
Types of changes
Internal changes:
refactor
- non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)Checklist
yarn run lint
.Terms