Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compacter look of recurrence, lines & dependencies in Edit Task modal #2811

Merged

Conversation

ilandikov
Copy link
Collaborator

Description

  • Make padding smaller around dependencies
  • Don't render empty space under dependency inputs when there are no dependencies (Make dependency inputs have the same spacing as date inputs in this case)
  • Smaller & symmetrical margins around the horizontal lines
  • Move recurrence in the same section with scheduled, due, starts date (As agreed here)

Motivation and Context

Make the Edit Task modal look better on all screens =)

How has this been tested?

Manual test in demo vault

Screenshots

Dependencies Before After
Without Снимок экрана 2024-05-07 в 23 12 36 Снимок экрана 2024-05-07 в 23 13 32
With Снимок экрана 2024-05-07 в 23 12 57 Снимок экрана 2024-05-07 в 23 14 22

Types of changes

Changes visible to users:

  • New feature (prefix: feat - non-breaking change which adds functionality)

Checklist

  • My code follows the code style of this project and passes yarn run lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change has adequate Unit Test coverage.
    • No CSS unit test available

Terms

@ilandikov
Copy link
Collaborator Author

Please note the diff in Dependency.svelte is not rendered correctly in GitHub, the change is 2 lines added + a lot of indentation

@ilandikov
Copy link
Collaborator Author

This will also fix the wrong width of the recurrence input that can be seen here - it is not matching the width with the date inputs

@claremacrae claremacrae added the scope: edit task The Create or edit task modal/dialog label May 7, 2024
@claremacrae
Copy link
Collaborator

Merging without testing, as I don't have time, and trust you to have tested... 😄

@claremacrae claremacrae merged commit e26c110 into obsidian-tasks-group:main May 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: edit task The Create or edit task modal/dialog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants