Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One shot GIFs do not play all their frames when using "Media Source" unlooped #10425

Open
XC3N opened this issue Mar 24, 2024 · 6 comments
Open

Comments

@XC3N
Copy link

XC3N commented Mar 24, 2024

Operating System Info

Windows 11

Other OS

No response

OBS Studio Version

30.1.0

OBS Studio Version (Other)

No response

OBS Studio Log URL

https://obsproject.com/logs/BiUh1OttLHyBYOME

OBS Studio Crash Log URL

No response

Expected Behavior

The GIF should play all of its frames and then disappear.

Current Behavior

The GIF plays about 90% of it's frames and then disappear.

Steps to Reproduce

1- add "media source"
2- set up a local .gif file
3 - make sure "loop" is unchecked
4- trigger GIF playback
The GIF plays about 90% of it's frames and then disappear

Anything else we should know?

I tried this on 3 different computers, also went through the trouble of completely reinstalling on the initial systme I had the problem with. This occurs on all 3 computers, including one that never had OBS installed before.

Here is a GIF I used to reproduce this issue, play in loop to see all frames, then play without loop on and you will see the left head never gets to play it's animation.

3headedmonkey

@RytoEX
Copy link
Member

RytoEX commented Mar 24, 2024

I've checked this again, as I did with #10386, and but I do see this now comparing frame by frame.

That said, Media Source is probably not the intended tool for GIFs (Image Source is). It's meant for video files. Convert the GIF to a video file and see if the issue still occurs.

@XC3N
Copy link
Author

XC3N commented Mar 24, 2024

I've checked this again, as I did with #10386, and but I do see this now comparing frame by frame.

That said, Media Source is probably not the intended tool for GIFs (Image Source is). It's meant for video files. Convert the GIF to a video file and see if the issue still occurs.

Unfortunately, image source is lacking some options I want to use, namely playback speed and "show nothing when playback ends"

Of course converting to video will not have the same issue, so there's a work around (although it requires additional processing since videos don't do alpha etc etc)

In the end this is a bug and it's up to the devs to decide whether or not they want to fix it, I just reopened it since I was able to reproduce it 100%

Thanks!

@RytoEX
Copy link
Member

RytoEX commented Mar 24, 2024

In the end this is a bug and it's up to the devs to decide whether or not they want to fix it, I just reopened it since I was able to reproduce it 100%

I didn't say it wasn't a bug. I simply pointed out that Media Source isn't particularly meant for (designed for, tested against) GIFs. Image Source has better GIF playback. I offered it as a workaround. That's all. I am a dev, and I typically decide if something is a bug or not. If I thought this were not at all a bug, I would have simply closed the Issue.

@XC3N
Copy link
Author

XC3N commented Mar 24, 2024

In the end this is a bug and it's up to the devs to decide whether or not they want to fix it, I just reopened it since I was able to reproduce it 100%

I didn't say it wasn't a bug. I simply pointed out that Media Source isn't particularly meant for (designed for, tested against) GIFs. Image Source has better GIF playback. I offered it as a workaround. That's all. I am a dev, and I typically decide if something is a bug or not. If I thought this were not at all a bug, I would have simply closed the Issue.

I apologize if my tone was misinterpreted, I wasn't being aggressive, just saying I agree with your workaround solution and pointing out additional problems.

I simply meant to say I am opening this to report a bug and seeing if it's something you guys want to fix since this is the only type of contribution I can make to the project.

@RytoEX
Copy link
Member

RytoEX commented Mar 24, 2024

One thing that would be helpful is knowing when this behavior first appeared in OBS. Testing in older versions would be appreciated.

@XC3N
Copy link
Author

XC3N commented Mar 25, 2024

Took some time to test various versions, an interesting trip down memory lane ;)

I isolated the behaviour to a specific version, and had some observations:

  • The regression got introduced in 19.0.1
  • On 17.0.2 (oldest I tested), 18.0.1, 18.0.2, the behaviour is as expected with one strange exception:
    • Most of the time (but not always) the automatic play when you start the software will have the playback problem. Other
      times, the playback completes as expected.
    • After the initial playback was completed (properly or not), subsequent plays work as expected.

Hope this helps!

(PS: to clarify what I was saying before, I meant to say I did not come here to demand a fix, just to report unusual behaviour and find out if it was something the team wants to fix, and if I could be of any assistance).

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants