Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OBS crashed when decklink output is auto started and the device is changed to different model #2494

Closed
afriza opened this issue Mar 13, 2020 · 2 comments · Fixed by #2620
Closed

OBS crashed when decklink output is auto started and the device is changed to different model #2494

afriza opened this issue Mar 13, 2020 · 2 comments · Fixed by #2620

Comments

@afriza
Copy link
Contributor

afriza commented Mar 13, 2020 •
edited
Loading

OBS crashed when decklink output is auto started and the device is changed to different model.

Expected Behavior

It should not crash. one option is to display empty selection if the device changed or not found.

Current Behavior

crash

Steps to Reproduce

  1. plug in "decklink mini monitor"
  2. enable auto start in the decklink output
  3. poweroff computer and change to "decklink mini monitor 4k"
  4. open OBS and it will crash

Additional information

Workaround: disable decklink output auto-start prior changing decklink device.
Tested with OBS 24.0.3 under Ubuntu 18.04.4. I haven't tested on other platform.
@afriza
Copy link
Contributor Author

afriza commented Apr 2, 2020 •
edited
Loading

Another workaround is to delete or edit the JSON files under

  • $HOME/.config/obs-studio/plugin_config/decklink-ouput-ui (Linux)
  • $HOME/Library/Application Support/obs-studio/plugin_config/decklink-ouput-ui (macOS)
rm $HOME/.config/obs-studio/plugin_config/decklink-ouput-ui/*.json

@afriza
Copy link
Contributor Author

afriza commented Apr 2, 2020 •
edited
Loading

Probably need to check if the device is nullptr before dereferencing it and return false

@afriza afriza mentioned this issue Apr 2, 2020
Merged
5 tasks
Oncorporation pushed a commit to Oncorporation/obs-studio that referenced this issue May 15, 2020
@afriza @Oncorporation
Decklink: Fix crash when no matching device
979c9a2 
OBS crashes when decklink output is auto started and the device is
removed or changed to different model while OBS is not running.

Fixes obsproject#2494
Oncorporation pushed a commit to Oncorporation/obs-studio that referenced this issue Jun 29, 2020
@afriza @Oncorporation
Decklink: Fix crash when no matching device
26bc8d0 
OBS crashes when decklink output is auto started and the device is
removed or changed to different model while OBS is not running.

Fixes obsproject#2494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Decklink: Fix crash when no matching device
1 participant
@afriza