Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings -> Output with Output Mode "Advanced": cannot view or edit encoder properties in Streaming tab when profile has encoder in it that is no longer available #3531

Open
YorVeX opened this issue Oct 1, 2020 · 8 comments
Labels
Confirmed This bug report has been confirmed by project members Good first issue New to contributing to OBS? Start here!

Comments

@YorVeX
Copy link

YorVeX commented Oct 1, 2020

Platform

Operating system and version: Windows 10 Pro Build 2004 (x64)
OBS Studio version: 26.0.0

Expected Behavior

In the Output settings in "Advanced" Output Mode when only the x264 encoder is available the encoder properties should still be shown and editable in the below window section.

Current Behavior

The encoder properties section just says "No properties available" and there doesn't seem to be any way to bring these settings up.

Steps to Reproduce

Run OBS 26.0.0 on a computer that only supports the x264 encoder (i.e. doesn't have any graphics device or QuickSync capable CPU), go to Settings -> Output and set "Output Mode" to "Advanced".

Additional information

On computers that offer more than one encoding option this problem doesn't occur.
This issue also existed in 25.0.8.

@Fenrirthviti
Copy link
Member

Please provide a log file.

@YorVeX
Copy link
Author

YorVeX commented Oct 1, 2020

Here is a log of a session where I started OBS, did the reproduction steps as mentioned above, then closed everything again:
2020-10-01 03-42-33.txt

Here's also a screenshot of the result:
Advanced-Output

@Fenrirthviti
Copy link
Member

Fenrirthviti commented Oct 1, 2020

It looks like you have imported or copied a profile from a system with an encoder selection that does not exist on this PC:

03:42:34.850: Encoder ID 'amd_amf_h264' not found
03:42:34.850: Encoder ID 'amd_amf_h264' not found

You can fix this by simply creating a new profile from the profile menu, but I agree that this is a bug we should address when an encoder is no longer available. It's a pretty rare edge case where this can actually happen.

@YorVeX YorVeX changed the title Settings -> Output with Output Mode "Advanced": cannot view or edit encoder properties in Streaming tab when only one encoder is available Settings -> Output with Output Mode "Advanced": cannot view or edit encoder properties in Streaming tab when profile has encoder in it that is no longer available Oct 1, 2020
@YorVeX
Copy link
Author

YorVeX commented Oct 1, 2020

Right, using a new profile fixes it. Thanks a lot for the quick help with this!

When I last used AMF that must have been 4 years ago or so, on a completely different computer even. But since I am lazy I always just copied the profiles over.

I changed the title to reflect that this was in fact the cause of the problem. Would be good if this could still be fixed, even when I agree that probably not many people will run into this.

@YorVeX
Copy link
Author

YorVeX commented Oct 1, 2020

Note for others running into this: if you don't want to recreate all your profiles like me you can simply edit \config\obs-studio\basic\profiles\your_profile_name\basic.ini with a text editor and in the [AdvOut] section delete the lines that say "Encoder=amd_amf_h264" and "RecEncoder=amd_amf_h264" (or whatever other invalid encoder you might have set there).

This has worked for me to fix this issue and still keep the other profile settings, no guarantees that it will work for anyone else, create backups of your profile files before you do this if you want to be on the safe side.

@WizardCM WizardCM added Confirmed This bug report has been confirmed by project members Good first issue New to contributing to OBS? Start here! labels Oct 1, 2020
@offthegrid-mike
Copy link
Contributor

I can help fix this issue.
What properties should we expected to show in this case?(when there is an encoder which is not found)

@YorVeX
Copy link
Author

YorVeX commented Dec 1, 2020

I don't know whether the question is directed at me or the main contributors of this project, but IMHO you should keep the behavior consistent with the rest of the UI. For example if an audio device is configured that went missing it looks like this:
image

So it should be similar if an encoder is configured that went missing.

@Mahas1234
Copy link

Are there any more fixes needed. I'm looking for first contribution.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed This bug report has been confirmed by project members Good first issue New to contributing to OBS? Start here!
Projects
None yet
Development

No branches or pull requests

5 participants