Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkeys trigger even when extra meta/modifier keys are held #4408

Closed
igavronski opened this issue Mar 29, 2021 · 11 comments · Fixed by #5095
Closed

Hotkeys trigger even when extra meta/modifier keys are held #4408

igavronski opened this issue Mar 29, 2021 · 11 comments · Fixed by #5095
Labels
Confirmed This bug report has been confirmed by project members

Comments

@igavronski
Copy link

igavronski commented Mar 29, 2021

Operating System Info

Windows 10

Other OS

No response

OBS Studio Version

26.1.2

OBS Studio Version (Other)

No response

OBS Studio Log URL

there is no need

OBS Studio Crash Log URL

No response

Expected Behavior

  1. Assign F3 to start recording
  2. Assign ALT+F3 to start virtual cam
  3. When pressing ALT+F3, start virtual cam but not start recording.

Current Behavior

Because OBS treats ALT+F3 as F3 as well, both start v cam and start recording fire when hitting ALT+F3

Steps to Reproduce

Already described in expected behaviour.

Anything else we should know?

Support channel members in Discord said it is expected behaviour. I politely discord.

@dodgepong
Copy link
Member

This would be better submitted on https://ideas.obsproject.com/ since this is technically intended behavior by Qt.

@Fenrirthviti
Copy link
Member

Going to re-open this and modify the request, as it's not very explicit on what's going on here, but this is something we should track and fixed. Original Mantis ticket here: https://obsproject.com/mantis/view.php?id=925

@Fenrirthviti Fenrirthviti reopened this Mar 30, 2021
@Fenrirthviti Fenrirthviti changed the title Fn key combinations are not Fn keys! Hotkeys trigger even when extra meta/modifier keys are held Mar 30, 2021
@igavronski
Copy link
Author

@Fenrirthviti thanks Joel. I guess treating both the key and alt+key the same way is not the expected behaviour for any user, regardless of Qt's defaults.

@berghetti
Copy link

berghetti commented Apr 2, 2021

Hi,
on my system
using obs --platform wayland ,
I get the same behavior.

OBS Studio - 26.1.2-344-gbaf980f7a (linux) (builded from source)
Linux debian 5.10.0-5-amd64 #1 SMP Debian 5.10.24-1 (2021-03-19) x86_64 GNU/Linux
debian_version: bullseye/sid

@Fenrirthviti
Copy link
Member

Hi,
on my system
using obs --platform wayland ,
I get the same behavior.

OBS Studio - 26.1.2-344-gbaf980f7a (linux) (builded from source)
Linux debian 5.10.0-5-amd64 #1 SMP Debian 5.10.24-1 (2021-03-19) x86_64 GNU/Linux
debian_version: bullseye/sid

This does not appear related to this bug report, please use the support channels (Discord/Forums) for more assistance instead of posting on an unrelated issue report.

@Fenrirthviti
Copy link
Member

Looks like you edited the original post. If you are unable to set hotkeys entirely, as your original post stated, you should use the support channels.

@Fenrirthviti Fenrirthviti added the Confirmed This bug report has been confirmed by project members label Apr 2, 2021
@lindenkron
Copy link

lindenkron commented Apr 25, 2021

Have this happening on Windows 10 OBS 26.1.1 64-bit as well. Still. I believe I reported this sometime on mantis a few years ago and it's still occurring. Edit Not on Mantis, had a conversation with Jim about it in DMs and it yielded nothing at the time.

It's obstructing to set Shift + F1, and have the F1 hotkey fire when you're clearly pressing Shift + F1 and not F1. Makes hotkey management painful, intentional behavior from QT or not - this shouldn't be how hotkeys behave.

@Fenrirthviti
Copy link
Member

Please note that anyone working to fix this issue should also check if the fix corrects #4655, as they should be caused by the same underlying issue with how hotkeys are being triggered.

@hoffr
Copy link

hoffr commented May 6, 2021

from #4655

It might seem different, but this is the exact same issue where hotkeys are not checking for their own exclusivity, which causes all sorts of weirdness to occur. "Modifier" keys are really any key held in addition to another. "L" could be considered a modifier key as far as the code is concerned. It's all the same underlying issue with how the Qt hotkey system (which is what we use) functions by default. If this turns out to not be solved by fixing #4408, we can reopen.

I'll reiterate though that in OBS I'm not able to assign a hotkey by pressing two keys at once unless one is a 'known' modifier (ctrl, shift, alt, etc), so creating a hypothetical hotkey L+G will set it to L on press of L, and with L held, on press of G it will be set only to G. Not sure if it's worth mentioning though

@RobMayer
Copy link

I hate to bump this, but I've been smacking my head against this issue for weeks now. Would very much love to see the PR merged.

@Fenrirthviti
Copy link
Member

We are planning on merging the PR, it just currently has some design issues that need to be addressed first. v27.1 has been in beta testing for a few weeks now, so additional reviews and testing has slowed down a bit. It's definitely on our radar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed This bug report has been confirmed by project members
Projects
None yet
7 participants