Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locking a scene source doesn't prevent dragging to resize #5724

Closed
ntoff opened this issue Jan 2, 2022 · 1 comment · Fixed by #5741
Closed

Locking a scene source doesn't prevent dragging to resize #5724

ntoff opened this issue Jan 2, 2022 · 1 comment · Fixed by #5741
Labels
Confirmed This bug report has been confirmed by project members

Comments

@ntoff
Copy link

ntoff commented Jan 2, 2022

Operating System Info

Windows 10

Other OS

No response

OBS Studio Version

27.2.0 Beta 2

OBS Studio Version (Other)

27.1.3 also affected

OBS Studio Log URL

https://obsproject.com/logs/e1L3O7O9QPrvUzVe

OBS Studio Crash Log URL

No response

Expected Behavior

Locking a scene source should prevent resizing or moving that source around.

Current Behavior

Locking a scene source merely hides the resize box (the red box that appears around a source in the preview window), but leaves it able to be resized if you guess where the resize handles are.

Steps to Reproduce

  1. Add a source, in my case it's a game capture set to capture specific window (heaven.exe from the unigine heaven benchmark)
  2. Make sure the source fills the entire scene, or take note of where the resize handles are (the little squares on the corners / sides of the bounding box)
  3. Click the padlock icon to lock the source
  4. Select the source in the "sources" list (as it's locked, you can't select it from the preview window, you must click on it in the sources list)
  5. Position the mouse cursor over where the resize handles are, note the cursor will change to the resize cursor, click and you can resize a "locked" source.

Anything else we should know?

Also happens in previous versions of obs (tested on 27.1.3) but I only just noticed it now while testing 27.2-beta2

@WizardCM WizardCM added the Confirmed This bug report has been confirmed by project members label Jan 2, 2022
@WizardCM
Copy link
Member

WizardCM commented Jan 2, 2022

I can confirm this issue exists as far back as OBS 20.0.0 (August 2017) when locking sources was introduced.

Any source that's locked just hides its anchors - the click targets for them still exist & the user can resize a locked source via drag - but only if the source is already selected in the list.

cg2121 added a commit to cg2121/obs-studio that referenced this issue Jan 5, 2022
cg2121 added a commit to cg2121/obs-studio that referenced this issue Jan 6, 2022
jp9000 pushed a commit that referenced this issue Jan 7, 2022
flaeri pushed a commit to flaeri/obs-studio that referenced this issue Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed This bug report has been confirmed by project members
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants