win-capture/graphics-hook: Fix try_lock_shmem_tex mutex deadlock bug #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible that the mutexes used with shared memory capture to return WAIT_ABANDONED if OBS is shut down abnormally while the mutex is locked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… get two mutexes,eventually may cause deadlock
if obsstudio shutdown abnormal,tex_mutexes may not be released(ReleaseMutex),at that time if use WaitForSingleObject to get mutexe WaitForSingleObject will return WAIT_ABANDONED and get lock,but try_lock_shmem_tex will not return,it will continue wait next mutexe。eventually the return WAIT_ABANDONED will not release infinite。this commit will fix this bug。