Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authors: Update Contributors list #1607

Merged
merged 1 commit into from
Jan 31, 2019

Conversation

admshao
Copy link
Contributor

@admshao admshao commented Jan 8, 2019

This was generated using this script
git shortlog -ns jp9000/master | awk '{$1=""; print}' | sed -e 's/^.//'
And manually editing the AUTHORS file later.

Should we also add email address?

This should ideally be re-run and updated prior to the release

@Xaymar
Copy link
Contributor

Xaymar commented Jan 8, 2019

I'm in this list twice, once with my full name and once without my full name and just my alias. I think you should group these by email, which hopefully reduces duplicates.

@pkviet
Copy link
Member

pkviet commented Jan 8, 2019

I'm in this list twice, once with my full name and once without my full name and just my alias. I think you should group these by email, which hopefully reduces duplicates.

A mailmap would be a solution.
https://git-scm.com/docs/git-shortlog

edit: there's already one; it just need to be updated. I'll see what I can do @admshao

@dodgepong
Copy link
Member

I would prefer this not be listed with my email address.

Co-authored-by: pkviet <pkv.stream@gmail.com>
@admshao
Copy link
Contributor Author

admshao commented Jan 8, 2019

No emails and removed duplicates.

@DDRBoxman DDRBoxman merged commit 72b8448 into obsproject:master Jan 31, 2019
@admshao admshao deleted the update-authors branch February 20, 2019 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants