Fix all warnings #81
Merged
Fix all warnings #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5339,7 +5339,9 @@ Read_1_Packet(RTMP *r, char *buf, unsigned int buflen) | |||
|
|
|||
| if (recopy) | |||
| { | |||
| len = (unsigned int)(ret) > buflen ? buflen : ret; | |||
There was a problem hiding this comment.
How about
len = (unsigned int)(ret) > buflen ? buflen : (unsigned int)ret;to keep differences minimal?
Gol-D-Ace
pushed a commit
to Gol-D-Ace/obs-studio
that referenced
this pull request
Feb 20, 2021
* Set the mp flag if MSVC * Add the fast link flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing special, just makes it compile without warnings.
Also, i believe the obs_data_item_set warnings were an actual bug, and not just warnings.