silence some matplotlib warnings #3330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just some code refactoring going on here, so no need to look at anything really |
Closed
when using tight_layout()
because it causes some problems when plotting with cartopy currently. should get unpinned again later
casting single item arrays to a scalar is deprecated in newer numpy and will result in errors at some point see numpy issue number 10404
setting an array element with a slice of a single-item array
QuLogic
reviewed
Jul 25, 2023
| @@ -434,7 +434,11 @@ def plot(self, outfile=None, show=True, fig=None, plot_x=True, | |||
| width = min(width, height * 4) | |||
| fig.set_figwidth(width) | |||
| plt.subplots_adjust(top=1, bottom=0, left=0, right=1) | |||
| plt.tight_layout() | |||
There was a problem hiding this comment.
Why do we call tight_layout on line 425 too? It seems enough to do it once after setting both width and height?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix some failing tests, mostly due to warnings
tight_layout()in some casesWhy was it initiated? Any relevant Issues?
Warnings in current test runs
PR Checklist
masterfor new features,maintenance_...for bug fixesno_cilabel can be added to skip CI buildsJust add the
build_docstag to this PR.Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
Please post a link to the relevant piece of documentation.
clients.fdsn) should be tested for the PR,just add the
test_networktag to this PR.CHANGELOG.txt.CONTRIBUTORS.txt.from all the CI builds look correct. Add the "upload_plots" tag so that plotting
outputs are attached as artifacts.
CODEOWNERSwith your github handleready for reviewlabel when you are ready for the PR to be reviewed.