-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spaces after readings for bracket notation to delimit words in sentences #29
Comments
Is this for the Ruby/HTML markup, or the bracket notation? The former is generating them correctly. |
Indeed, that would be for the bracket notation — which I and other users may prefer for legacy & compatibility reasons. Merci :) |
Awesome, that helps narrow it down. When you say it's not "rendered correctly" in some situations: is there some other tool/plugin that you're using as well that's converting the bracket notation into some other format? Would you be able to provide a screenshot of a sentence that doesn't render correctly, so we have a test case to work with while we're coding the fix? |
The fix is probably to just add a space at this line: https://github.com/obynio/anki-japanese-furigana/blob/master/reading.py#L153 Before:
After:
Changed it on my copy and observed that the plugin now does the annotation correctly. |
This issue was fixed and released in 1.4.6 🫡 |
As highlighted by another user on https://ankiweb.net/shared/info/678316993, spaces are not added between words (after the generated reading and before the next character), so that furigana are not rendered correctly in some situations unless fixed manually.
The text was updated successfully, but these errors were encountered: