Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.1] Fix hr_interview dependency on smtpclient #11

Closed
dreispt opened this issue Jul 18, 2014 · 4 comments
Closed

[6.1] Fix hr_interview dependency on smtpclient #11

dreispt opened this issue Jul 18, 2014 · 4 comments
Milestone

Comments

@dreispt
Copy link
Member

dreispt commented Jul 18, 2014

6.1 tests are failing because:

except_orm: (u'Error', u"You try to install module 'hr_interview' that depends
on module 'smtpclient'.\nBut the latter module is not available in your system.")
@bwrsandman bwrsandman added this to the 6.1 milestone Oct 20, 2014
@bwrsandman
Copy link

bwrsandman pushed a commit to savoirfairelinux/hr that referenced this issue Oct 20, 2014
@dreispt
Copy link
Member Author

dreispt commented Oct 20, 2014

IMO the dependency should be removed. Or at least isolated in a non-OCA module.

@bwrsandman
Copy link

Will the module work without that deps?

bwrsandman pushed a commit to savoirfairelinux/hr that referenced this issue Oct 20, 2014
@dreispt
Copy link
Member Author

dreispt commented Oct 20, 2014

Didn't read the code, but from the description of smtpclient I don't see why it shouldn't.
I'm for a quick fix removing the features where the dependency is required.
Probably current Email Templates can do the job, and anyone interested can properly restore them in a later PR.

sambarros pushed a commit to sambarros/hr that referenced this issue Jul 26, 2018
Mraimou pushed a commit to camptocamp/hr that referenced this issue Nov 25, 2019
Fix pep8 (redundant key in dict)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants