Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] pos_pricelist: Tax included prices #137

Closed
jonerikceberio opened this issue Dec 9, 2016 · 0 comments
Closed

[8.0] pos_pricelist: Tax included prices #137

jonerikceberio opened this issue Dec 9, 2016 · 0 comments

Comments

@jonerikceberio
Copy link

jonerikceberio commented Dec 9, 2016

The pos_pricelist engine does not take into account the included taxes in the same way that the one in sale.order does: In sale/sale.py - product_id_change line 1206:

       price = self.pool.get('product.pricelist').price_get(cr, uid, [pricelist],
                product, qty or 1.0, partner_id, ctx)[pricelist]
        if price is False:
            warn_msg = _("Cannot find a pricelist line matching this product and quantity.\n"
                    "You have to change either the product, the quantity or the pricelist.")

            warning_msgs += _("No valid pricelist line found ! :") + warn_msg +"\n\n"
        else:
            price = self.pool['account.tax']._fix_tax_included_price(cr, uid, price, taxes, result['tax_id'])
            result.update({'price_unit': price})

So a method is called to ALWAYS take into account the included taxes if they are defined in the product. And this matches the impossibility to set a fiscal position that maps an included tax to an excluded one (although it can be easily overpassed by modifying the view).
The pos_pricelist engine does not take this into account and therefore the calculated price is different.

First steps to fix it in #138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants