wrong field name in _refund_cleanup_lines patch method
#147
Comments
|
Can you please do the PR? https://odoo-community.org/page/Contribute |
|
Hey @pedrobaeza . Sure we will, we are reworking this method at the moment. We have better approach for patching this using index to update values from super and not copy/pasting original Odoo method as there are problems with current approach for example:
We are also thinking that If dropped, new |
|
OK, great. The code for this module can be very ugly, so any improvement is welcome. NOTE: I'm not a user of this module nor proper reviewer for it, but general community manager for this kind of kick-off. |
- _refund_cleanup_lines now uses index to add claim values, there is no need to C/P Odoo's code to acheive this - _refund_cleanup_lines now returns empty list for account.invoice.tax calls to it, this is needed because origin tax lines are sum-up of all taxes and in case of claim not all invoice lines are refunded. This also fixes wrong field name, see OCA#147
- _refund_cleanup_lines now uses sorted recordset to add claim values, there is no need to C/P Odoo's code to acheive this - _refund_cleanup_lines now returns empty list for account.invoice.tax calls to it, this is needed because origin tax lines are sum-up of all taxes and in case of claim not all invoice lines are refunded. - This also fixes wrong field name, see OCA#147
- _refund_cleanup_lines now uses sorted recordset to add claim values, there is no need to C/P Odoo's code to acheive this - _refund_cleanup_lines now returns empty list for account.invoice.tax calls to it, this is needed because origin tax lines are sum-up of all taxes and in case of claim not all invoice lines are refunded. - This also fixes wrong field name, see OCA#147
- _refund_cleanup_lines now uses sorted recordset to add claim values, there is no need to C/P Odoo's code to acheive this - _refund_cleanup_lines now returns empty list for account.invoice.tax calls to it, this is needed because origin tax lines are sum-up of all taxes and in case of claim not all invoice lines are refunded. - This also fixes wrong field name, see OCA#147
- _refund_cleanup_lines now uses sorted recordset to add claim values, there is no need to C/P Odoo's code to acheive this - _refund_cleanup_lines now returns empty list for account.invoice.tax calls to it, this is needed because origin tax lines are sum-up of all taxes and in case of claim not all invoice lines are refunded. - This also fixes wrong field name, see OCA#147
- _refund_cleanup_lines now uses sorted recordset to add claim values, there is no need to C/P Odoo's code to acheive this - _refund_cleanup_lines now returns empty list for account.invoice.tax calls to it, this is needed because origin tax lines are sum-up of all taxes and in case of claim not all invoice lines are refunded. - This also fixes wrong field name, see OCA#147
- _refund_cleanup_lines now uses sorted recordset to add claim values, there is no need to C/P Odoo's code to acheive this - _refund_cleanup_lines now returns empty list for account.invoice.tax calls to it, this is needed because origin tax lines are sum-up of all taxes and in case of claim not all invoice lines are refunded. - This also fixes wrong field name, see OCA#147
- _refund_cleanup_lines now uses sorted recordset to add claim values, there is no need to C/P Odoo's code to acheive this - _refund_cleanup_lines now returns empty list for account.invoice.tax calls to it, this is needed because origin tax lines are sum-up of all taxes and in case of claim not all invoice lines are refunded. - This also fixes wrong field name, see OCA#147
|
There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
There is mistake here that causes that
invoice_line_tax_idsare not appended resulting in incorrect tax for refund invoice.invoice_line_tax_idshould beinvoice_line_tax_idsOdoo 10.0 account.invoice.line
The text was updated successfully, but these errors were encountered: