[8.0] crm_rma_lot_mass_return gives javascript error on playAlert

[RoelAdriaans]

With crm_rma_lot_mass_return installed, adding products we get an error:

ReferenceError: playAlert is not defined

Linked to https://github.com/OCA/rma/blob/8.0/crm_rma_lot_mass_return/static/src/js/barcode_text.js#L67 and https://github.com/OCA/rma/blob/8.0/crm_rma_lot_mass_return/static/src/js/barcode_text.js#L84 ..

Tested with Firefox 43 on Linux, Chrome on Windows

[RoelAdriaans]

Linked to https://github.com/OCA/rma/blob/8.0/crm_rma_lot_mass_return/templates/search_view.xml#L6

The file /crm_rma_lot_mass_return/static/lib/alert.js does not exist.

ping @osvalr , because you've committed this code, maybe left behind in a .gitignore?

[osvalr]

@RoelAdriaans-B-informed I'm checking this out

[osvalr]

@RoelAdriaans-B-informed as you pointed out alert.js was ignored by the .gitignore and it's necessary to allow this file allow ../static/lib but maintain the rule for generic /lib as it's currently listed

[RoelAdriaans]

@osvalr True, but you can to an git add -f to add the file, ignoring the gitignore file

[osvalr]

@RoelAdriaans-B-informed but valid directories as static/lib/ need be added without any forcing IMHO, please see OCA/maintainer-tools#173 and let me know your comments

[gurneyalex]

OCA/maintainer-tools#173 is now merged

[gurneyalex]

The correct template gitignore file is https://github.com/OCA/maintainer-quality-tools/blob/master/sample_files/.gitignore though

[RoelAdriaans]

Thanks for the merge @gurneyalex
.gitignore is now updated, and file can be added cleanly.

[RoelAdriaans]

Fixed with the merging of #75