-
Notifications
You must be signed in to change notification settings - Fork 71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @faucomte97)
game_frontend/src/global.d.ts
line 2 at r1 (raw file):
declare var OnetrustActiveGroups: string declare function loadPyodide(any: any): Promise<any>
We could keep the Pyodide interface and make it return Promise<Pyodide>
? Also, the argument could be called options: any
🙂
game_frontend/src/pyodide/webWorker.ts
line 14 at r1 (raw file):
importScripts('https://cdn.jsdelivr.net/pyodide/v0.20.0/full/pyodide.js') pyodide = await loadPyodide({ indexURL: "https://cdn.jsdelivr.net/pyodide/v0.20.0/full/"
Oh, I think we can remove this indexUrl
and just call it without any options 🙂
game_frontend/src/pyodide/webWorker.ts
line 32 at r1 (raw file):
from js import Object from pyodide import to_js import sys
Organise imports 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @razvan-pro)
game_frontend/src/global.d.ts
line 2 at r1 (raw file):
Previously, razvan-pro (Razvan Mahu) wrote…
We could keep the Pyodide interface and make it return
Promise<Pyodide>
? Also, the argument could be calledoptions: any
🙂
Done.
Code quote:
interface Pyodide {
loadPackage(packages: string[]): Promise<void>
runPythonAsync(pythonCode: string): Promise<any>
}
game_frontend/src/pyodide/webWorker.ts
line 14 at r1 (raw file):
Previously, razvan-pro (Razvan Mahu) wrote…
Oh, I think we can remove this
indexUrl
and just call it without any options 🙂
Done.
game_frontend/src/pyodide/webWorker.ts
line 32 at r1 (raw file):
Previously, razvan-pro (Razvan Mahu) wrote…
Organise imports 🙂
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
Codecov Report
@@ Coverage Diff @@
## master #1642 +/- ##
==========================================
+ Coverage 67.96% 67.98% +0.02%
==========================================
Files 164 164
Lines 3328 3327 -1
Branches 280 280
==========================================
Hits 2262 2262
+ Misses 1038 1037 -1
Partials 28 28
|
This change is