Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

feat: Create custom action to stop games in django admin #1761

Merged
merged 8 commits into from
Apr 27, 2023

Conversation

faucomte97
Copy link
Contributor

@faucomte97 faucomte97 commented Apr 19, 2023

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Apr 19, 2023
Copy link
Contributor

@cewei8483 cewei8483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @faucomte97)


aimmo/admin.py line 29 at r2 (raw file):

def stop_game(game_admin, request, queryset):
    for game in queryset:
        game.status = "s"

Maybe use Game.STOPPED instead of "s"?

Copy link
Contributor

@cewei8483 cewei8483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, 1 of 2 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

Copy link
Contributor Author

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @cewei8483)

Copy link
Contributor Author

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r3.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @cewei8483)

Copy link
Contributor Author

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, 1 of 1 files at r6.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #1761 (142c206) into master (a7574d4) will increase coverage by 0.44%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1761      +/-   ##
==========================================
+ Coverage   66.32%   66.76%   +0.44%     
==========================================
  Files         179      180       +1     
  Lines        3661     3719      +58     
  Branches      255      264       +9     
==========================================
+ Hits         2428     2483      +55     
- Misses       1201     1205       +4     
+ Partials       32       31       -1     
Impacted Files Coverage Δ
example_project/settings.py 0.00% <ø> (ø)
example_project/test_settings.py 100.00% <ø> (ø)
game_frontend/src/components/ConsoleBar/index.js 100.00% <ø> (ø)
game_frontend/src/components/FindMeButton/index.js 100.00% <ø> (ø)
game_frontend/src/components/LogEntries/index.js 92.30% <ø> (ø)
...ame_frontend/src/components/NavigationBar/index.js 27.77% <ø> (ø)
...ame_frontend/src/components/RunCodeButton/index.js 97.29% <ø> (ø)
game_frontend/src/containers/IDEConsole/index.js 81.25% <ø> (+4.10%) ⬆️
..._frontend/src/redux/features/AvatarWorker/epics.js 42.10% <ø> (ø)
...ntend/src/redux/features/AvatarWorker/operators.js 100.00% <ø> (ø)
... and 21 more

... and 2 files with indirect coverage changes

@faucomte97 faucomte97 merged commit bce704d into master Apr 27, 2023
@faucomte97 faucomte97 deleted the add_stop_game_action_admin branch April 27, 2023 10:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants