-
Notifications
You must be signed in to change notification settings - Fork 71
feat: Create custom action to stop games in django admin #1761
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @faucomte97)
aimmo/admin.py
line 29 at r2 (raw file):
def stop_game(game_admin, request, queryset): for game in queryset: game.status = "s"
Maybe use Game.STOPPED instead of "s"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, 1 of 2 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @cewei8483)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r3.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @cewei8483)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, 1 of 1 files at r6.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
Codecov Report
@@ Coverage Diff @@
## master #1761 +/- ##
==========================================
+ Coverage 66.32% 66.76% +0.44%
==========================================
Files 179 180 +1
Lines 3661 3719 +58
Branches 255 264 +9
==========================================
+ Hits 2428 2483 +55
- Misses 1201 1205 +4
+ Partials 32 31 -1
|
This change is