feat: 1752 kurono badges #1767
feat: 1752 kurono badges #1767
Conversation
There was a problem hiding this comment.
Reviewed 16 of 17 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @SKairinos)
game_frontend/src/components/Badge/badges.js line 37 at r5 (raw file):
message: 'You picked up your first artefact!', img: PickupBadge, name: 'Pickup artefact'
Something about these badges isn't working right
game_frontend/src/pyodide/badges.ts line 34 at r5 (raw file):
} = await response.json(); for (var i = 0; i < responseJson.passed.length; i++) {
can we have let here?
game_frontend/src/pyodide/badges.ts line 42 at r5 (raw file):
return badges; }
Add a new line please
There was a problem hiding this comment.
Reviewed 1 of 1 files at r6.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @SKairinos)
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)
game_frontend/src/components/Badge/badges.js line 37 at r5 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Something about these badges isn't working right
following up with Rebecca
game_frontend/src/pyodide/badges.ts line 34 at r5 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
can we have
lethere?
done
game_frontend/src/pyodide/badges.ts line 42 at r5 (raw file):
Previously, faucomte97 (Florian Aucomte) wrote…
Add a new line please
done
There was a problem hiding this comment.
Reviewed 1 of 1 files at r7, 2 of 2 files at r8, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SKairinos)
There was a problem hiding this comment.
Reviewed 3 of 4 files at r9, 1 of 1 files at r10, 1 of 1 files at r11, all commit messages.
Reviewable status:
Codecov Report
@@ Coverage Diff @@
## master #1767 +/- ##
==========================================
- Coverage 66.76% 66.32% -0.44%
==========================================
Files 180 182 +2
Lines 3719 3715 -4
Branches 264 258 -6
==========================================
- Hits 2483 2464 -19
- Misses 1205 1220 +15
Partials 31 31
|
There was a problem hiding this comment.
Reviewable status:
Description
How Has This Been Tested?
Checklist:
This change is