-
Notifications
You must be signed in to change notification settings - Fork 71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 5 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)
aimmo/models.py
line 220 at r2 (raw file):
@receiver(models.signals.pre_save, sender=UserProfile) def create_worksheet_badge(instance: UserProfile, **_kwargs):
Do we want to add tests for the cases handled in this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, 4 of 4 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1829 +/- ##
===========================================
+ Coverage 70.60% 84.95% +14.34%
===========================================
Files 190 38 -152
Lines 3950 1216 -2734
Branches 272 117 -155
===========================================
- Hits 2789 1033 -1756
+ Misses 1132 159 -973
+ Partials 29 24 -5 |
This change is