Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

fix: track worksheet badges #1829

Merged
merged 16 commits into from
Nov 14, 2023
Merged

fix: track worksheet badges #1829

merged 16 commits into from
Nov 14, 2023

Conversation

SKairinos
Copy link
Collaborator

@SKairinos SKairinos commented Nov 10, 2023

This change is Reviewable

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 5 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)


aimmo/models.py line 220 at r2 (raw file):

@receiver(models.signals.pre_save, sender=UserProfile)
def create_worksheet_badge(instance: UserProfile, **_kwargs):

Do we want to add tests for the cases handled in this function?

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, 4 of 4 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #1829 (e2b4345) into master (8cc5023) will increase coverage by 14.34%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1829       +/-   ##
===========================================
+ Coverage   70.60%   84.95%   +14.34%     
===========================================
  Files         190       38      -152     
  Lines        3950     1216     -2734     
  Branches      272      117      -155     
===========================================
- Hits         2789     1033     -1756     
+ Misses       1132      159      -973     
+ Partials       29       24        -5     

see 155 files with indirect coverage changes

@SKairinos SKairinos merged commit e7dfe13 into master Nov 14, 2023
8 checks passed
@SKairinos SKairinos deleted the worksheet_badges branch November 14, 2023 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants