main.yml

[Abdulrahim2567]

Please check out the Ocaml 5.0.0+trunk+serial yml file I tried to move from the Drone CI to GitHub Actions.

[Sudha247]

Thanks, this is neat! The code looks correct to me, although I'm not sure why the GitHub Actions job isn't triggered with the PR.

I'd rename the file to something more generic like main.yml since other jobs in the travis workflow need to be also included in this. Are you able to do the same for the other jobs too?

[Abdulrahim2567]

Thanks, this is neat! The code looks correct to me, although I'm not sure why the GitHub Actions job isn't triggered with the PR.

I'd rename the file to something more generic like main.yml since other jobs in the travis workflow need to be also included in this. Are you able to do the same for the other jobs too?

I will work on the other jobs and commit them ASAP.

[Abdulrahim2567]

@Sudha247 @shakthimaan please review the latest I have made to this commit

[Abdulrahim2567]

@Sudha247 @shakthimaan An attempt to fix #275 . I have added the other jobs from Drone CI to GitHub actions please take a look at them :)

[Sudha247]

Thanks @Abdulrahim2567! I'll try to activate this run on a local branch and get back to you.

[Abdulrahim2567]

Thanks for having a look at the pull request. I will be waiting for your feedback. @Sudha247

[Abdulrahim2567]

@Sudha247 just relaxed the on [push] constraint for the workflow to make it run on all branch branches, Could you please take a look at it? :)

[Abdulrahim2567]

@Sudha247 I also tested it on my branch and it looks great. There is a new pull request coming from my branch starting with Abdulrahim2567

[shakthimaan]

There is a new pull request coming from my branch

Please do not create multiple pull requests for the same issue. We will lose the conversation and the context. You can choose to rebase the commits to a single commit in the PR.

[Abdulrahim2567]

@shakthimaan Hello sir, I already closed the pull request just so we don't lose context of this PR :)

[Abdulrahim2567]

@shakthimaan @Sudha247 Hi, I just looked up this workflow run and I got an unexpected error, what could be wrong?. Please take a look:

[Abdulrahim2567]

runs passed so far:-

[Abdulrahim2567]

Been trying to figure out what went wrong for hours now, any pointers to a possible solution?

[Abdulrahim2567]

@Sudha247 @shakthimaan I just updated this workflow and removed every instance of sudo chown -R opam . but still got an error on this script USE_SYS_DUNE_HACK=1 RUN_CONFIG_JSON=run_config_filtered.json make ocaml-versions/5.0.0+stable.bench. Here is a the visual.

Any idea on what could've gone wrong?

[Sudha247]

Discussed this with @shakthimaan offline, I suspect the run might be failing due to the CPU number 5 specified here.

GitHub Actions runners typically have only 2 cores, making only 0 and 1 valid CPU numbers. Drone seems to fallback on the available CPUs, but GitHub Actions doesn't. We need to find a viable way to change this in the CI.

[Abdulrahim2567]

@Sudha247 Ahh I see. What do you think we should do now. Is there anyway which can us to solve this issue?
Or anything possible I can do for this whilst we find a possible solution?

[shakthimaan]

failing due to the CPU number 5

For each of the entries in the main.yml file, before the TAG='"run_in_ci"'... step is invoked, add a sed command to replace the --cpu-list 5 to --cpu-list 1 for the respective .json file being used.

[Abdulrahim2567]

@shakthimaan @Sudha247 I just added a sed command to replace --cpu-list 5 to --cpu-list 1 for each .json file used by each job but got the following result for 5.0.0+stable. Did I miss something?
I also tried running sed for the run_config.json but then I got the same results which led me to using sed

[Sudha247]

The sed command to replace CPU number is correct, but it's called before the generating the config file. Some suggestions are below to fix it. The same applies for all the sed commands used here.

[Abdulrahim2567]

@Sudha247 @shakthimaan Hello, I monitored the run which was triggered after modifying all sed commands from the workflow and got this issue to deal with.
ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/home/runner/.local/lib/python3.8/site-packages/markupsafe/__init__.py)
coming from test_notebooks, any pointers to a possible fix?

The runs Passed so far

[shakthimaan]

I monitored the run which was triggered after modifying all sed commands from the workflow

In future, please test the changes locally on your system to see if it works, before pushing an update to the PR.

ImportError: cannot import name 'soft_unicode' from 'markupsafe'

This could be related, pallets/markupsafe#284.

[Abdulrahim2567]

@shakthimaan okay no problem sir, I will keep that in mind before any future PR

[Abdulrahim2567]

@Sudha247 @shakthimaan I just updated the workflow to use markupsafe 2.0.1 and it worked out well please check it out