Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ls_name for unit logical symbol #387

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Fix ls_name for unit logical symbol #387

merged 1 commit into from
Apr 9, 2024

Conversation

n-osborne
Copy link
Contributor

This PR fixes #385

Along with #386, this also fixes ortac#207

@n-osborne n-osborne requested a review from shym March 13, 2024 08:49
@n-osborne
Copy link
Contributor Author

CI is green and this is minimal and trivial modifications.
I'm merging at the end of the day to move on with the release.

@n-osborne n-osborne removed the request for review from shym April 8, 2024 10:08
@n-osborne n-osborne merged commit 367bb8a into ocaml-gospel:main Apr 9, 2024
3 checks passed
@n-osborne n-osborne deleted the fix-fs_unit-ls_name branch April 9, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariojppereira mariojppereira Awaiting requested review from mariojppereira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Values of type unit are named unit Ortac swaps the type unit and the value ()
1 participant
@n-osborne