Fix is_ts_tuple
#386
Merged
Fix is_ts_tuple
#386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-osborne
force-pushed
the
fix-is_ts_tuple
branch
from
ec16af8
to
4439876
Compare
shym
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to change the implementation of the
Ttypes.is_ts_tuplefunction so that it doesnt confuseunitfor a tuple of length 0.This has the immediate benefit of concentrating the logic in the function rather than having to check that a type symbol is not
ts_unitbefore callingis_ts_tuple(hence the simplifcation of the condition inTyping.process_val_spec.This also improves the state of ortac#207