This repository has been archived by the owner on Jun 21, 2024. It is now read-only.
changes to the PUSH_EXN_HANDLER/POP_EXN_HANDLER assembly #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e problematic depdendencies between instructions
|
I think this is fine, but some comments in amd64.S need updating. e.g. SWITCH_C_TO_CAML says that it clobbers %r11, but with this patch it clobbers %r10 also. |
|
My only concern was whether clobbering |
|
I think this should now cover all the places in the documentation that need to be changed. Thanks for the review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes to the PUSH_EXN_HANDLER/POP_EXN_HANDLER assembly to avoid some problematic depdendencies between instructions