This repository has been archived by the owner on Jun 21, 2024. It is now read-only.
remove some unused rpc consumers #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm in favour of this PR. It makes it easier to understand how the domain API is used elsewhere in the codebase by removing entry points that never happen. LGTM |
|
Happy to remove it. I should mention that work-sharing in the major GC was not explored rigorously. This was before sandmark existed. That said, we can retrieve the design from git history if need be. |
sadiqj
pushed a commit
to sadiqj/ocaml
that referenced
this pull request
Jan 10, 2022
…used_rpc_code remove some unused rpc consumers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes two sets of code:
Both make use of the domain rpc mechanism but are no longer in use.