Skip to content
This repository has been archived by the owner on Jun 21, 2024. It is now read-only.

no-effect-syntax: remove effects from typedtree #458

Merged

Conversation

Sudha247
Copy link
Collaborator

This patch removes effect syntax from typedtree, addressing #457. The typed AST does not contain effects anymore, enabling external applications using the AST to work with domains-only Multicore (no-effect-syntax branch).

@EduardoRFS
Copy link
Contributor

Tried with ocaml-lsp and it doesn't crashes anymore, which is great, still not working for stdlib value, probably because there is still some difference between the cmi on 4.10 and cmi on the no-effect-syntax

@EduardoRFS
Copy link
Contributor

There is two additional commits on this branch, it keeps merlin working, the important thing is the typedtree have a compatible format also the ids for the predef types are identical

https://github.com/EduardoRFS/ocaml/commits/4.10.0%2Btries

@Sudha247
Copy link
Collaborator Author

Sudha247 commented Jan 4, 2021

Thanks @EduardoRFS! Added the patches to this PR.

@kayceesrk
Copy link
Contributor

There is a CI failure, but this is unrelated to the PR. I've restarted the job, but merging this anyway. Thanks @Sudha247 and @EduardoRFS!

@kayceesrk kayceesrk merged commit f7310b0 into ocaml-multicore:no-effect-syntax Jan 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants