Skip to content
This repository has been archived by the owner on Jun 21, 2024. It is now read-only.

Replace Op_val with Field #506

Merged
merged 2 commits into from
Mar 24, 2021

Conversation

Sudha247
Copy link
Collaborator

Changes usages of Op_val (x)[i] to Field (x, i). Op_val was supposedly used at a time Field was not working with multicore. They are both same and the latter seems to be more widely used in trunk.

Copy link
Collaborator

@ctk21 ctk21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of places that need fixing which look like typos. Otherwise good.

runtime/floats.c Outdated Show resolved Hide resolved
runtime/floats.c Outdated Show resolved Hide resolved
runtime/minor_gc.c Outdated Show resolved Hide resolved
@ctk21
Copy link
Collaborator

ctk21 commented Mar 24, 2021

Thanks! merging

@ctk21 ctk21 merged commit abbff11 into ocaml-multicore:4.12+domains+effects Mar 24, 2021
sadiqj pushed a commit to sadiqj/ocaml that referenced this pull request Jan 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants