Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backports for 3.8.2 #7907

Closed
6 of 7 tasks
Alizter opened this issue Jun 6, 2023 · 5 comments
Closed
6 of 7 tasks

backports for 3.8.2 #7907

Alizter opened this issue Jun 6, 2023 · 5 comments
Milestone

Comments

@rgrinberg
Copy link
Member

Let's add this one as well #7418

@emillon
Copy link
Collaborator

emillon commented Jun 13, 2023

@Alizter please don't edit the list. also regarding #7908, is this something that needs to delay 3.8.2 (for example a regression introduced in 3.8.1) or just a nice to have?

@Alizter
Copy link
Collaborator Author

Alizter commented Jun 13, 2023

This is a regression introduced in 3.8 which highlights two issues:

  • We have an issue with (memo) cycle detection (prob not important)
  • There is a cycle with coq install rules that needs to be broken. roughly
coq.install -> theory -> coqc for config -> coq.install

I would like for the second one, if we get around to fixing it, to be included in 3.8.2.

@emillon
Copy link
Collaborator

emillon commented Jun 13, 2023

OK, thanks for the explanation. Let's put it this way: 3.8.2 is not blocked on this. A fix for this can be included in 3.8.2 but that will depend on the fix.

@ejgallego
Copy link
Collaborator

ejgallego commented Jun 13, 2023

#7908 was introduced in 3.7.0 .

Indeed none of the open Coq bugs are blockers for 3.8.2, tho the above bug is kind of serious I'm afraid, but need to investigate more.

@emillon emillon closed this as completed Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants