Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format using ocamlformat #8

Closed
rgrinberg opened this issue Dec 12, 2019 · 3 comments
Closed

Format using ocamlformat #8

rgrinberg opened this issue Dec 12, 2019 · 3 comments

Comments

@rgrinberg
Copy link
Member

Does it make sense to vendor ocamlformat and all of its dependencies for this?

@andreypopp
Copy link
Member

I'd like to be able for ocaml-lsp to use ocamlformat program installed by opam/esy ‚ I think it's important for users to be able update ocamlformat and ocaml-lsp independently.

If for some group of users (thinking of vscode) we want to provide a workflow which doesn't requires opam/esy then we can ship an ocamlformat binary prebuilt with vscode extension and make sure ocaml-lsp can find it.

@rgrinberg
Copy link
Member Author

Okay, that sounds like a convincing argument against vendoring ocamlforamt itself. It's especially important given that the version of ocamlformat must be mandated for all contributors.

@smorimoto
Copy link
Member

Implemented in #89.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants