-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format using ocamlformat #8
Comments
I'd like to be able for ocaml-lsp to use ocamlformat program installed by opam/esy ‚ I think it's important for users to be able update ocamlformat and ocaml-lsp independently. If for some group of users (thinking of vscode) we want to provide a workflow which doesn't requires opam/esy then we can ship an ocamlformat binary prebuilt with vscode extension and make sure ocaml-lsp can find it. |
Okay, that sounds like a convincing argument against vendoring ocamlforamt itself. It's especially important given that the version of ocamlformat must be mandated for all contributors. |
Implemented in #89. |
Does it make sense to vendor ocamlformat and all of its dependencies for this?
The text was updated successfully, but these errors were encountered: