Remove dependency on bytes package #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since ocaml-re now required OCaml 4.02.3 or later.
|
Thanks David. I wish we'd have a way to apply this change across the board in opam though. I think lots of dune using packages are making this packaging inaccuracy. |
|
It's not just opam, though - in this case the |
|
opam is an unusual customer, though - it's not as if systems with ocaml and jbuilder and no ocamlfind are common place! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ocaml-re now required OCaml 4.02.3 or later.
It's a slight nuisance for opam's vendored build, since by default it's built without
ocamlfindpresent.