Update re to 1.7.2 #3241
Merged
Update re to 1.7.2 #3241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AltGr - you'll need to blow the Travis build cache in order for the |
|
Still fails after a cache wipe... maybe some travis tweaking is required |
|
@AltGr - I don't think you wiped all the caches. I'm fairly sure you need to wipe both the cache for this PR and also the master cache. All my tests with this are working (especially if I manually |
dra27
force-pushed
the
re-1.7.2
branch
2 times, most recently
from
7657935
to
de022bb
Compare
|
Btw the patch here is no longer necessary (as of 1.7.3) |
|
I know - I was going to close this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice to have another build in src_ext which now natively supports jbuilder! Alas, it temporarily requires a patch (see ocaml/ocaml-re#155)