Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debugger: avoid off-by-one overflow in debugger socket path #1753

Merged
merged 2 commits into from
May 4, 2018
Merged

debugger: avoid off-by-one overflow in debugger socket path #1753

merged 2 commits into from
May 4, 2018

Commits on May 2, 2018

  1. debugger: avoid off-by-one overflow in debugger socket path 

    Modern gcc have a `-Werror=stringop-truncation` warning that tells
us that the strncpy used to copy the CAML_DEBUG_SOCKET value from
the environment misses out the space for a terminating NUL.

Rather than silently truncate the path, this patch raises an
exception if the path is too long, and also fixes the off-by-one
in the strncpy invocation.

with feedback from Stephen Dolan
    @avsm
    avsm committed May 2, 2018
    Configuration menu
    Copy the full SHA
    8cea98c View commit details
    Browse the repository at this point in the history

Commits on May 4, 2018

  1. Merge branch 'trunk' into debug-socket-len

    @avsm
    avsm committed May 4, 2018
    Configuration menu
    Copy the full SHA
    a43fc76 View commit details
    Browse the repository at this point in the history