Failure to run docs on windows.

[jordwalke]

I think something is just forgetting to set the binary/text channel mode on the output:

odoc: internal error, uncaught exception:
      Failure("output_value: not a binary channel")
      Raised by primitive operation at file "src/odoc/root.ml", line 33, characters 2-28
      Called from file "src/odoc/compilation_unit.ml", line 29, characters 2-23
      Called from file "cmdliner_term.ml", line 25, characters 19-24
      Called from file "cmdliner.ml", line 116, characters 32-39
        odoc _doc/_odoc/pkg/hello-reason/page-index.odoc (exit 2)

Complete repro steps (only requires npm be installed)

npm install -g esy
git clone https://github.com/esy-ocaml/hello-reason.git
cd hello-reason
esy
esy doc

[ulrikstrid]

After some changes to the code I hit this instead

ocamlopt .ppx/95c43a5e8eeb6d851e1995d1bca87765/ppx.exe (exit 2)
(cd C:/LocalDevelopment/revery/_esy/default/store/b/revery-37b15f89\default && C:/LocalDevelopment/.esy/3_/i/ocaml-4.7.1003-d6263879/bin\ocamlopt.opt.exe -o .ppx/95c43a5e8eeb6d851e1995d1bca87765/ppx.exe -I C:/LocalDevelopment/.esy/3_/i/ocaml-4.7.1003-d6263879/lib/ocaml\compiler-libs -I C:/LocalDevelopment/.esy/3_/i/opam__s__lwt__ppx-opam__c__1.2.1-8fb7029d/lib\lwt_ppx -I C:/LocalDevelopment/.esy/3_/i/opam__s__ocaml_migrate_parsetree-opam__c__1.2.0-a491cf88/lib\ocaml-migrate-parsetree -I C:/LocalDevelopment/.esy/3_/i/opam__s__ppx__derivers-opam__c__1.0-de0fe9e4/lib\ppx_derivers -I C:/LocalDevelopment/.esy/3_/i/opam__s__ppx__tools__versioned-opam__c__5.2.1-f6b2c1dd/lib\ppx_tools_versioned -I C:/LocalDevelopment/.esy/3_/i/opam__s__result-opam__c__1.3-30781bb9/lib\result C:/LocalDevelopment/.esy/3_/i/ocaml-4.7.1003-d6263879/lib/ocaml\compiler-libs\ocamlcommon.cmxa C:/LocalDevelopment/.esy/3_/i/opam__s__ppx__derivers-opam__c__1.0-de0fe9e4/lib\ppx_derivers\ppx_derivers.cmxa C:/LocalDevelopment/.esy/3_/i/opam__s__result-opam__c__1.3-30781bb9/lib\result\result.cmxa C:/LocalDevelopment/.esy/3_/i/opam__s__ocaml_migrate_parsetree-opam__c__1.2.0-a491cf88/lib\ocaml-migrate-parsetree\migrate_parsetree.cmxa C:/LocalDevelopment/.esy/3_/i/opam__s__ppx__tools__versioned-opam__c__5.2.1-f6b2c1dd/lib\ppx_tools_versioned\ppx_tools_versioned.cmxa C:/LocalDevelopment/.esy/3_/i/opam__s__lwt__ppx-opam__c__1.2.1-8fb7029d/lib\lwt_ppx\ppx_lwt.cmxa
.ppx/95c43a5e8eeb6d851e1995d1bca87765/ppx.ml)
'x86_64-w64-mingw32-as' is not recognized as an internal or external command,
operable program or batch file.
File ".ppx/95c43a5e8eeb6d851e1995d1bca87765/ppx.ml", line 1:
Error: Assembler error, input left in file C:\Users\ULRIK~1.STR\AppData\Local\Temp\camlasm4106c8.s

Is this something we can solve on the esy side of things?
Specifically this: 'x86_64-w64-mingw32-as' is not recognized as an internal or external command, operable program or batch file.
cc @andreypopp @jordwalke

[aantron]

I believe this was resolved by #286, and the second issue is not an odoc issue, so closing this. Please reopen if that's wrong.