-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve markup for @-tags #329
Comments
No progress here either. This kind of @-tag in CCArray namely:
ends up in the following markup: <dl>
<dt>since</dt>
<dd>1.2, but only</dd>
</dl>
<dl>
<dt>since</dt>
<dd>2.1 with labels</dd>
</dl> The fact that there are two lists actually make it easier to style. But if we'd put that in a single list it would be annoying to style. But in any case this markup does not allow to use in page search in chrome to find e.g. "since 2.1" which is annoying (In general it seems that in page search in chrome only works across A tentative better markup would be to turn that into: <ul class="odoc-tags">
<li class="since"><span class="tag">since</span> , 1.2 but only</li>
<li class="since"><span class="tag">since</span> 2.1 with labels</li>
</ul> |
It's a bit sad, since that is actually a good use case for |
Indeed but somehow But the lack of in-page search is deal breaker. Somehow it should be formalized in the standards, AFAIK it's not. I'm also quite annoyed by chrome's search behaviour for |
In #607 we establish the markup structure. The following remains to be done: |
This has been raised again on https://discuss.ocaml.org/t/documentation-created-by-dune-build-doc-looks-ugly |
The markup for @-tags is poor. No class labelling for the list of tags, no spans to distinguish the different tag constituents, no class to target/distinguish the different tags
Contrast the markup here:
https://docs.mirage.io/fmt/Fmt/index.html#val-set_utf_8
https://b0-system.github.io/odig/doc/fmt/Fmt/index.html#val-set_utf_8
or here with a few different tags like
@
since,@
deprecated (note the@
raise is not used there though)https://docs.mirage.io/ocaml/String/index.html
https://b0-system.github.io/odig/doc/ocaml/Stdlib/String/index.html
Also In general I'd move away from
dl
for lists of elements: they are harder to style than it should be, because list elements are made of two consecutive blocks of elements rather than a single element. It's much easier to styleli
elements with properlyspan
ned and classified elements.The text was updated successfully, but these errors were encountered: