conf-unwind: Add support for fedora-base distributions #25914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need to do this on all conf- packages? |
mseri
reviewed
May 24, 2024
| @@ -10,7 +10,7 @@ depexts: [ | |||
| ["libunwind-dev"] {os-family = "debian" | os-family = "ubuntu"} | |||
| ["libunwind-devel"] {os-distribution = "centos"} | |||
| ["libunwind-devel"] {os-distribution = "rhel"} | |||
| ["libunwind-devel"] {os-distribution = "fedora"} | |||
| ["libunwind-devel"] {os-distribution = "fedora" | os-family = "fedora"} | |||
There was a problem hiding this comment.
Suggested change
| ["libunwind-devel"] {os-distribution = "fedora" | os-family = "fedora"} | |
| ["libunwind-devel"] {os-family = "fedora"} |
Why not this? Can it have fedora distribution but not family?
There was a problem hiding this comment.
mmh, good question, I thought Fedora itself had ID_LIKE = rhel or something but it turns out they do not (maybe they had in the past?). So I guess this should be safe to do.
There was a problem hiding this comment.
I'll keep it as is, can be revisited in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.