Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] asn1-combinators (0.2.1) #15757

Closed
wants to merge 1 commit into from

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Jan 28, 2020

CHANGES:

CHANGES:

* disallow various constructs as suggested by ITU-T Rec X.690 (by @pqwy)
  * redundant OID component forms (X.690 8.20.2)
  * redundant integer forms (X.690 8.3.2)
  * empty integer (X.690 8.3.1, reported in mirleft/ocaml-asn1-combinators#23 by @emillon)
  * constructed strings in DER
* deeper implict -> explicit over choice (follow-up to v0.2.0 entry, by @pqwy)
* handle long-form length overflow (reported in mirleft/ocaml-asn1-combinators#24 by @emillon, fixed by @pqwy)
* disallow primitive with indefinite length (introduced in the bugfix above,
  reported by @emillon, fixed in mirleft/ocaml-asn1-combinators#32 by @hannesm)
* disallow nonsensical bitstring unused values (X690 8.6.2, reported in mirleft/ocaml-asn1-combinators#26
  by @NathanReb, fixed by @pqwy)
* fix non-continuous bit_string_flags (X680 22.6, reported in mirleft/ocaml-asn1-combinators#25 by @wiml,
  fixed by @pqwy)
* use Alcotest instead of oUnit for unit tests (by @pqwy)
* use dune as build system (by @pqwy, superseeds mirleft/ocaml-asn1-combinators#22)
* use bigarray-compat (mirleft/ocaml-asn1-combinators#27 by @TheLortex) and stdlib-shims (mirleft/ocaml-asn1-combinators#29 by @XVilka)
* raise lower bound to OCaml 4.05.0 (mirleft/ocaml-asn1-combinators#31 by @hannesm)
@kit-ty-kate
Copy link
Member

CI is green but I have a couple requests. The dune version required is 1.2 as described in your dune-project file, this should be reflected in the opam file as well.

Also, looking at the dune-project file inside the archive, the version field seems a little odd:

(version v0.2.1)

It containers the v prefix but the version number does not have it, is there any chance that could be changed? The version field is stored in the dune-package file and I'm not sure how it is used but this can be used in the future anyway.

synopsis: "Embed typed ASN.1 grammars in OCaml"
build: [ ["dune" "subst"] {pinned}
["dune" "build" "-p" name "-j" jobs ]
["dune" "runtest"] {with-test} ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
["dune" "runtest"] {with-test} ]
["dune" "runtest" "-p" name "-j" jobs] {with-test} ]

hannesm added a commit to hannesm/ocaml-asn1-combinators that referenced this pull request Jan 29, 2020
hannesm added a commit to hannesm/opam-repository that referenced this pull request Jan 29, 2020
CHANGES:

* packaging improvements: add lower bound to dune dependency, improve test
  invocation, remove version from dune-project
  (reported by @kit-ty-kate in ocaml#15757 fixed by @hannesm)
@hannesm
Copy link
Member Author

hannesm commented Jan 29, 2020

thanks @kit-ty-kate, superseeded by a 0.2.2 release in #15762

@hannesm hannesm closed this Jan 29, 2020
@hannesm hannesm deleted the release-asn1-combinators-0.2.1 branch January 29, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants