[wip] port to Dune #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anil Madhavapeddy <anil@recoil.org>
Signed-off-by: Anil Madhavapeddy <anil@recoil.org>
Signed-off-by: Anil Madhavapeddy <anil@recoil.org>
|
@avsm what is missing to merge this ? |
|
AFAICT, the |
suggestion from @hannesm in mirleft#22
|
Thanks for the review @hannesm -- I've pushed those fixes now |
|
Thx, dune'd. |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Jan 28, 2020
CHANGES: * disallow various constructs as suggested by ITU-T Rec X.690 (by @pqwy) * redundant OID component forms (X.690 8.20.2) * redundant integer forms (X.690 8.3.2) * empty integer (X.690 8.3.1, reported in mirleft/ocaml-asn1-combinators#23 by @emillon) * constructed strings in DER * deeper implict -> explicit over choice (follow-up to v0.2.0 entry, by @pqwy) * handle long-form length overflow (reported in mirleft/ocaml-asn1-combinators#24 by @emillon, fixed by @pqwy) * disallow primitive with indefinite length (introduced in the bugfix above, reported by @emillon, fixed in mirleft/ocaml-asn1-combinators#32 by @hannesm) * disallow nonsensical bitstring unused values (X690 8.6.2, reported in mirleft/ocaml-asn1-combinators#26 by @NathanReb, fixed by @pqwy) * fix non-continuous bit_string_flags (X680 22.6, reported in mirleft/ocaml-asn1-combinators#25 by @wiml, fixed by @pqwy) * use Alcotest instead of oUnit for unit tests (by @pqwy) * use dune as build system (by @pqwy, superseeds mirleft/ocaml-asn1-combinators#22) * use bigarray-compat (mirleft/ocaml-asn1-combinators#27 by @TheLortex) and stdlib-shims (mirleft/ocaml-asn1-combinators#29 by @XVilka) * raise lower bound to OCaml 4.05.0 (mirleft/ocaml-asn1-combinators#31 by @hannesm)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress port to shift to the Dune build system, which in turn permits the library to embedded as a single
dune buildas part of a monorepo. More information on this vendoring mechanism is available here.I'm still working on the port, but opening this PR to track it.