Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OCaml 4.08 support #29

Closed
wants to merge 2 commits into from
Closed

Add OCaml 4.08 support #29

wants to merge 2 commits into from

Conversation

XVilka
Copy link

@XVilka XVilka commented Jun 27, 2019

No description provided.

@XVilka
Copy link
Author

XVilka commented Jun 27, 2019

Also, since there is a long time error for OCaml 4.03 and OCaml 4.04 versions, maybe it makes sense to drop their support? After all they were released long time ago, 4.08 is out, and 4.09 will be ready quite soon as well...

<><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><><><>
+ /home/travis/.opam/opam-init/hooks/sandbox.sh "build" "dune" "subst" (CWD=/home/travis/.opam/ocaml-base-compiler.4.03.0/.opam-switch/build/asn1-combinators.0.2.0)
+ /home/travis/.opam/opam-init/hooks/sandbox.sh "build" "dune" "build" "-p" "asn1-combinators" "-j" "1" (CWD=/home/travis/.opam/ocaml-base-compiler.4.03.0/.opam-switch/build/asn1-combinators.0.2.0)
-       ocamlc src/.asn1_combinators.objs/byte/asn_combinators.{cmi,cmo,cmt} (exit 2)
- (cd _build/default && /home/travis/.opam/ocaml-base-compiler.4.03.0/bin/ocamlc.opt -w -40 -g -bin-annot -I src/.asn1_combinators.objs/byte -I src/.asn1_combinators.objs/public_cmi -I /home/travis/.opam/ocaml-base-compiler.4.03.0/lib/bigarray-compat -I /home/travis/.opam/ocaml-base-compiler.4.03.0/lib/cstruct -I /home/travis/.opam/ocaml-base-compiler.4.03.0/lib/ptime -I /home/travis/.opam/ocaml-base-compiler.4.03.0/lib/result -I /home/travis/.opam/ocaml-base-compiler.4.03.0/lib/zarith -no-alias-deps -o src/.asn1_combinators.objs/byte/asn_combinators.cmo -c -impl src/asn_combinators.ml)
- File "src/asn_combinators.ml", line 94, characters 16-34:
- Error: Unbound value M2.max_binding_opt
[ERROR] The compilation of asn1-combinators failed at
        "/home/travis/.opam/opam-init/hooks/sandbox.sh build dune build -p
        asn1-combinators -j 1".
#=== ERROR while compiling asn1-combinators.0.2.0 =============================#
# context     2.0.3 | linux/x86_64 | ocaml-base-compiler.4.03.0 | pinned(file:///home/travis/build/mirleft/ocaml-asn1-combinators)
# path        ~/.opam/ocaml-base-compiler.4.03.0/.opam-switch/build/asn1-combinators.0.2.0
# command     ~/.opam/opam-init/hooks/sandbox.sh build dune build -p asn1-combinators -j 1
# exit-code   1
# env-file    ~/.opam/log/asn1-combinators-24700-ffb3fd.env
# output-file ~/.opam/log/asn1-combinators-24700-ffb3fd.out
### output ###
#       ocamlc src/.asn1_combinators.objs/byte/asn_combinators.{cmi,cmo,cmt} (exit 2)
# (cd _build/default && /home/travis/.opam/ocaml-base-compiler.4.03.0/bin/ocamlc.opt -w -40 -g -bin-annot -I src/.asn1_combinators.objs/byte -I src/.asn1_combinators.objs/public_cmi -I /home/travis/.opam/ocaml-base-compiler.4.03.0/lib/bigarray-compat -I /home/travis/.opam/ocaml-base-compiler.4.03.0/lib/cstruct -I /home/travis/.opam/ocaml-base-compiler.4.03.0/lib/ptime -I /home/travis/.opam/ocam[...]
# File "src/asn_combinators.ml", line 94, characters 16-34:
# Error: Unbound value M2.max_binding_opt

@XVilka
Copy link
Author

XVilka commented Jun 27, 2019 •
edited

Nevermind, not a portable solution across OCaml versions. What do you think about using stdlib-shims to help with this one?

@XVilka
Copy link
Author

XVilka commented Jul 1, 2019

OK, should be fine after #27 is merged and #30 is fixed.

@XVilka XVilka changed the title Add OCaml 4.08 in Travis CI Add OCaml 4.08 support Jul 1, 2019
@hannesm
Copy link
Member

hannesm commented Jan 28, 2020

thanks, this is supeerseeded by #31

@hannesm hannesm closed this Jan 28, 2020
hannesm added a commit to hannesm/opam-repository that referenced this pull request Jan 28, 2020
@hannesm
[new release] asn1-combinators (0.2.1)
2d1679e 
CHANGES:

* disallow various constructs as suggested by ITU-T Rec X.690 (by @pqwy)
  * redundant OID component forms (X.690 8.20.2)
  * redundant integer forms (X.690 8.3.2)
  * empty integer (X.690 8.3.1, reported in mirleft/ocaml-asn1-combinators#23 by @emillon)
  * constructed strings in DER
* deeper implict -> explicit over choice (follow-up to v0.2.0 entry, by @pqwy)
* handle long-form length overflow (reported in mirleft/ocaml-asn1-combinators#24 by @emillon, fixed by @pqwy)
* disallow primitive with indefinite length (introduced in the bugfix above,
  reported by @emillon, fixed in mirleft/ocaml-asn1-combinators#32 by @hannesm)
* disallow nonsensical bitstring unused values (X690 8.6.2, reported in mirleft/ocaml-asn1-combinators#26
  by @NathanReb, fixed by @pqwy)
* fix non-continuous bit_string_flags (X680 22.6, reported in mirleft/ocaml-asn1-combinators#25 by @wiml,
  fixed by @pqwy)
* use Alcotest instead of oUnit for unit tests (by @pqwy)
* use dune as build system (by @pqwy, superseeds mirleft/ocaml-asn1-combinators#22)
* use bigarray-compat (mirleft/ocaml-asn1-combinators#27 by @TheLortex) and stdlib-shims (mirleft/ocaml-asn1-combinators#29 by @XVilka)
* raise lower bound to OCaml 4.05.0 (mirleft/ocaml-asn1-combinators#31 by @hannesm)
@hannesm hannesm mentioned this pull request Jan 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XVilka @hannesm